X-notifier broken on Firefox 48 because ioService.newChannelFromURI was removed

Submitted by Loiro on Sun, 03/13/2016 - 06:22

Forums:

Bug 1254752 removed deprecated functions from nsIIoservice.

It seems X-notifier uses ioService.newChannelFromURI, so now Handler.js:198 throws

gmail 0 TypeError: ioService.newChannelFromURI is not a function
hotmail 0 TypeError: ioService.newChannelFromURI is not a function

Loiro

Tue, 03/15/2016 - 03:18

It seems easy to fix. In Handler.js line 431, use

Components.utils.import("resource://gre/modules/NetUtil.jsm");
var channel = NetUtil.newChannel({uri: aURL, loadUsingSystemPrincipal: true});

instead of

var ioService = Components.classes["@mozilla.org/network/io-service;1"].getService(Ci.nsIIOService);
var uri = ioService.newURI(aURL, null, null);
var channel = ioService.newChannelFromURI(uri);

Loiro

Thu, 03/24/2016 - 06:35

Bug 1257339 brought back the newChannel() API.

The API is still deprecated, so the code should be changed anyways, but it's less urgent.